Fix Terrain Disappearing #5829
Closed
Fix Terrain Disappearing #5829
+48
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comments explaining rough purpose of the centroid to header. Fixed up DEBUG_CENTROIDS rendering and materials
|
@Web-eWorks dammit I did some testing last night and this doesn't 100% fix it, It's much improved but I still get some drop-out 😔 |
|
@fluffyfreak I assume it means that the understanding of the bug was mostly correct? |
|
@impaktor it's on the right track, I just don't understand what exactly has changed that it's become a problem suddenly |
I assumed this was something that's been in master a long time (since no change has been made to terrain / render in a long time, that I can think of), but was rare (as it's not been reported before). |
|
I'm going to close this for now whilst I rethink the problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5806 ... if we're lucky
Switched to using the recalculated
m_centroidinstead ofm_clipCentroidwhich is surprisingly far below the surface on asteroids. I believe some terrains generate heights which are FAR above expected which buriesm_clipCentroidmuch further below the surface than expected.All of this will need some testing with things to look out for like: